Attention is currently required from: Tarun Tuli, Kapil Porwal, Sridhar Siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69680 )
Change subject: soc/intel/meteorlake: Skip setting D0I3 bit for HECI devices
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69680/comment/b294929a_0e9bca60
PS1, Line 9: This patch skips setting D0I3 bit for all HECI devices by FSP.
Can you please add reason for it?
@Sridhar, this is the backporting of the ADL CL, please take a look into the original CL for the reasoning.
TL;DR: This is to ensure FSP can skip setting D0i3 bit for CSE and coreboot is able to sent EOP and put the HECI devices into the D0i3.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69680
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c3765ce41f192ab5f5ff176e0a2b49b312d18d2
Gerrit-Change-Number: 69680
Gerrit-PatchSet: 1
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Wed, 16 Nov 2022 07:30:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment