Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph. Hello build bot (Jenkins), Subrata Banik, Tim Wawrzynczak, Patrick Rudolph, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61331
to look at the new patch set (#7).
Change subject: intel/common/block/pcie: Add NULL/count check in pcie_rp_update_devtree ......................................................................
intel/common/block/pcie: Add NULL/count check in pcie_rp_update_devtree
pcie_rp_update_devicetree function takes pcie_rp_group strcuture as an argument and SoC code passes the parameter in this structure.
This pointer can be NULL and common code may try to dereference this NULL pointer.
Also, group might have no data and SoC may pass this by indicating group count as zero (For example, for CPU or TBT root ports).
These checks will prevent function from executing redundant code and returning early from the call as it's not required.
BUG=b:210933428 BRANCH=None TEST=check if function returns early for group count 0 and there is no issue while booting board in case group count = 0.
Change-Id: I132319bb05fdef1590c18302fc64cc76e15bea6d Signed-off-by: MAULIK V VAGHELA maulik.v.vaghela@intel.com --- M src/soc/intel/common/block/pcie/pcie_rp.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/61331/7