Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42865 )
Change subject: mb/x/acpi_tables: Do minor cleanup on includes ......................................................................
mb/x/acpi_tables: Do minor cleanup on includes
Change-Id: I7a6ddf95d085490d52e00ade7bac23e8c8849427 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/ocp/tiogapass/acpi_tables.c M src/mainboard/scaleway/tagada/acpi_tables.c 3 files changed, 1 insertion(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/42865/1
diff --git a/src/mainboard/intel/harcuvar/acpi_tables.c b/src/mainboard/intel/harcuvar/acpi_tables.c index cfe0caa..5040b0b 100644 --- a/src/mainboard/intel/harcuvar/acpi_tables.c +++ b/src/mainboard/intel/harcuvar/acpi_tables.c @@ -10,8 +10,6 @@ #include <soc/acpi.h> #include <soc/nvs.h>
-extern const unsigned char AmlCode[]; - void acpi_create_gnvs(struct global_nvs *gnvs) { acpi_init_gnvs(gnvs); diff --git a/src/mainboard/ocp/tiogapass/acpi_tables.c b/src/mainboard/ocp/tiogapass/acpi_tables.c index f6947a2..300e8f6 100644 --- a/src/mainboard/ocp/tiogapass/acpi_tables.c +++ b/src/mainboard/ocp/tiogapass/acpi_tables.c @@ -1,10 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <acpi/acpi.h> #include <acpi/acpi_gnvs.h> -#include <intelblocks/acpi.h> -#include <soc/acpi.h> - -extern const unsigned char AmlCode[];
void acpi_create_gnvs(struct global_nvs *gnvs) { diff --git a/src/mainboard/scaleway/tagada/acpi_tables.c b/src/mainboard/scaleway/tagada/acpi_tables.c index cfe0caa..a251d22 100644 --- a/src/mainboard/scaleway/tagada/acpi_tables.c +++ b/src/mainboard/scaleway/tagada/acpi_tables.c @@ -1,17 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <types.h> #include <acpi/acpi.h> #include <acpi/acpi_gnvs.h> -#include <device/device.h> -#include <cpu/x86/msr.h> - -#include <intelblocks/acpi.h> -#include <soc/acpi.h> #include <soc/nvs.h>
-extern const unsigned char AmlCode[]; - void acpi_create_gnvs(struct global_nvs *gnvs) { acpi_init_gnvs(gnvs);
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42865 )
Change subject: mb/x/acpi_tables: Do minor cleanup on includes ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42865 )
Change subject: mb/x/acpi_tables: Do minor cleanup on includes ......................................................................
Patch Set 2: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42865 )
Change subject: mb/x/acpi_tables: Do minor cleanup on includes ......................................................................
Patch Set 2: Code-Review+2
Hello build bot (Jenkins), David Guckian, Paul Menzel, Vanessa Eusebio, Angel Pons, HAOUAS Elyes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42865
to look at the new patch set (#3).
Change subject: mb/x/acpi_tables: Do minor cleanup on includes ......................................................................
mb/x/acpi_tables: Do minor cleanup on includes
Change-Id: I7a6ddf95d085490d52e00ade7bac23e8c8849427 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/ocp/tiogapass/acpi_tables.c M src/mainboard/scaleway/tagada/acpi_tables.c 3 files changed, 1 insertion(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/42865/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42865 )
Change subject: mb/x/acpi_tables: Do minor cleanup on includes ......................................................................
Patch Set 3: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42865 )
Change subject: mb/x/acpi_tables: Do minor cleanup on includes ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42865 )
Change subject: mb/x/acpi_tables: Do minor cleanup on includes ......................................................................
mb/x/acpi_tables: Do minor cleanup on includes
Change-Id: I7a6ddf95d085490d52e00ade7bac23e8c8849427 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42865 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/ocp/tiogapass/acpi_tables.c M src/mainboard/scaleway/tagada/acpi_tables.c 3 files changed, 1 insertion(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/intel/harcuvar/acpi_tables.c b/src/mainboard/intel/harcuvar/acpi_tables.c index c51bd69..821de5f 100644 --- a/src/mainboard/intel/harcuvar/acpi_tables.c +++ b/src/mainboard/intel/harcuvar/acpi_tables.c @@ -8,8 +8,6 @@ #include <soc/acpi.h> #include <soc/nvs.h>
-extern const unsigned char AmlCode[]; - void acpi_create_gnvs(struct global_nvs *gnvs) { acpi_init_gnvs(gnvs); diff --git a/src/mainboard/ocp/tiogapass/acpi_tables.c b/src/mainboard/ocp/tiogapass/acpi_tables.c index f6947a2..300e8f6 100644 --- a/src/mainboard/ocp/tiogapass/acpi_tables.c +++ b/src/mainboard/ocp/tiogapass/acpi_tables.c @@ -1,10 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <acpi/acpi.h> #include <acpi/acpi_gnvs.h> -#include <intelblocks/acpi.h> -#include <soc/acpi.h> - -extern const unsigned char AmlCode[];
void acpi_create_gnvs(struct global_nvs *gnvs) { diff --git a/src/mainboard/scaleway/tagada/acpi_tables.c b/src/mainboard/scaleway/tagada/acpi_tables.c index c51bd69..a251d22 100644 --- a/src/mainboard/scaleway/tagada/acpi_tables.c +++ b/src/mainboard/scaleway/tagada/acpi_tables.c @@ -2,14 +2,8 @@
#include <acpi/acpi.h> #include <acpi/acpi_gnvs.h> -#include <device/device.h> - -#include <intelblocks/acpi.h> -#include <soc/acpi.h> #include <soc/nvs.h>
-extern const unsigned char AmlCode[]; - void acpi_create_gnvs(struct global_nvs *gnvs) { acpi_init_gnvs(gnvs);
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)