Attention is currently required from: Dan Callaghan. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58647 )
Change subject: mb/google/brya/var/taeko: add HPS as generic I2C peripheral ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/brya/variants/taeko/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/58647/comment/6af8bfdd_77b25fdb PS1, Line 287: register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)" # EN_HPS_PWR I'm not sure if taeko has the reset GPIO pinned out or not?
https://review.coreboot.org/c/coreboot/+/58647/comment/0f6cbfeb_c4c50822 PS1, Line 288: ACPI_IRQ_WAKE_LEVEL_HIGH same statement about the wake here, if it is required you will also need
`register "wake" = "GPE0_DW1_03"`
-
Tim Wawrzynczak (Code Review)