Attention is currently required from: Francois Toguo Fotso, Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro, Kane Chen, Patrick Rudolph, Karthik Ramasubramanian.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57685 )
Change subject: soc/intel/common: Add CPU Crashlog PCI driver
......................................................................
Patch Set 7:
(5 comments)
File src/soc/intel/common/block/crashlog/cpu_crashlog.c:
https://review.coreboot.org/c/coreboot/+/57685/comment/84da8391_28daae14
PS6, Line 5: #include "crashlog_lib.h"
nit - group of local includes follows group of system includes
Ack
https://review.coreboot.org/c/coreboot/+/57685/comment/ba01228e_b405e448
PS6, Line 16: CPU_CRASHLOG_CMD_DISABLE
enum may be ?
Ack
https://review.coreboot.org/c/coreboot/+/57685/comment/0f718590_e565e7b2
PS6, Line 24: cpu_crashlog_info
can be move structures into *.h file which may be local like crashlog_lib. […]
Ack
https://review.coreboot.org/c/coreboot/+/57685/comment/02710009_f96e85e3
PS6, Line 85: 1000
macro for timeout ?
Ack
https://review.coreboot.org/c/coreboot/+/57685/comment/70aa9052_5510f6e5
PS6, Line 263: if (!is_dev_enabled(dev))
Would .init ever get called on a disabled device?
Nope 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5cb61fa2570adcfe51680141ee12e0e83930bb19
Gerrit-Change-Number: 57685
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 09 Feb 2022 12:56:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment