Attention is currently required from: Dinesh Gehlot, Julius Werner, Subrata Banik.
Yu-Ping Wu has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83685?usp=email )
Change subject: src: Include new gbb flag to enforce cse sync
......................................................................
Patch Set 1:
(2 comments)
File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/83685/comment/f0ddf185_a2372d3a?usp... :
PS1, Line 454: CSME
If we often call CSE instead of CSME in coreboot, use `CSE` in the Kconfig name as well (and also in the vboot patch)?
https://review.coreboot.org/c/coreboot/+/83685/comment/641ade63_d2c49d87?usp... :
PS1, Line 455: Sync
nit: `sync`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83685?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6352959e1e898a90b4c6e12a22f8d6513f90ded9
Gerrit-Change-Number: 83685
Gerrit-PatchSet: 1
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 30 Jul 2024 07:42:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No