Attention is currently required from: Kyösti Mälkki.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69677 )
Change subject: intel/haswell,lynxpoint: Fix out() parameter order
......................................................................
Patch Set 1:
(1 comment)
File src/southbridge/intel/lynxpoint/pmutil.c:
https://review.coreboot.org/c/coreboot/+/69677/comment/b4a863f6_07cd3a11
PS1, Line 359: outl(TCOSCI_STS, get_pmbase() + gpe0_sts);
Maybe use write_pmbase32() in following up
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife134ef6d508113e3cd27b6352ee5044aee43744
Gerrit-Change-Number: 69677
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 16 Nov 2022 12:37:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment