[M] Change in coreboot[master]: mb/google/nissa/var/yaviks: Update GPIOs to support yavilla - coreboot-gerrit

12 Apr 2023


      Attention is currently required from: Tarun Tuli, Chen-Tsung Hsieh, Shon Wang.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74264 )
Change subject: mb/google/nissa/var/yaviks: Update GPIOs to support yavilla
......................................................................
Patch Set 11:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74264/comment/f6ec797c_ec0d884c 
PS10, Line 9: an additional nissa reference board
a variant of yaviks
File src/mainboard/google/brya/variants/yaviks/fw_config.c:
https://review.coreboot.org/c/coreboot/+/74264/comment/7d90fda7_e04e2f4e 
PS11, Line 62: gpio_configure_pads
why not gpio_padbased_override?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74264
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I831b199055c931e7a4a393eeb9e75e83c8ae3c3a
Gerrit-Change-Number: 74264
Gerrit-PatchSet: 11
Gerrit-Owner: Shon Wang shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@chromium.org
Gerrit-Reviewer: Derek Huang derekhuang@google.com
Gerrit-Reviewer: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kevin Chiu kevin.chiu@quanta.corp-partner.google.com
Gerrit-CC: Robert Chen robert.chen@quanta.corp-partner.google.com
Gerrit-CC: Tony Huang tony-huang@quanta.corp-partner.google.com
Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Chen-Tsung Hsieh chentsung@chromium.org
Gerrit-Attention: Shon Wang shon.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 12 Apr 2023 02:16:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment