Change in coreboot[master]: util/apcb: Add apcb_v3_edit tool - coreboot-gerrit

4 Jan 2022


      Attention is currently required from: Rob Barnes.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60281 )
Change subject: util/apcb: Add apcb_v3_edit tool
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File util/apcb/apcb_v3_edit.py:
https://review.coreboot.org/c/coreboot/+/60281/comment/4944e659_03c9fd8a 
PS2, Line 81: fromhex
...
Are you suggesting to check that the hex byte is in range? As is, this will cause an ValueError and  […]
I as referring to the --hex. If you pass in `--hex=false` we shouldn't call fromhex. Looks like you got rid of the --hex so all inputs are in hex format?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/60281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9148977c415df41210a3a13a1cd9b3bc1504a480
Gerrit-Change-Number: 60281
Gerrit-PatchSet: 3
Gerrit-Owner: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Comment-Date: Tue, 04 Jan 2022 21:24:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Rob Barnes robbarnes@google.com
Gerrit-MessageType: comment