Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Paul Menzel, Subrata Banik.
Karthik Ramasubramanian has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/85219?usp=email )
Change subject: src/soc/intel/cmn/blk/cse: Log cse sync information ......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/85219/comment/2038e862_f3a9c266?usp... : PS2, Line 809: elog_add_event_byte(ELOG_TYPE_FW_CSE_SYNC, CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE)?
`spaces required around that '?' (ctx:VxE)`
Please fix. Also mentioned to use `ENV_RAMSTAGE` and not `CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE)`.
https://review.coreboot.org/c/coreboot/+/85219/comment/1337a1c1_be2b2d4e?usp... : PS2, Line 810: ELOG_FW_LATE_CSE_SYNC:ELOG_FW_EARLY_CSE_SYNC);
`labels should not be indented`
Please fix. Without space before and after `:`, checkpatch is treating this line as a label.