Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76032?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for DdiPortFHpd dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for DdiPortFHpd dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="DdiPortFHpd" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: Ib6a7fb481beb3118767a04fa6be2bb8ad6550d4e Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb M src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/76032/1
diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb index c5e0237..a961e95 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb +++ b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb @@ -8,7 +8,7 @@ register DdiPortBHpd = true register DdiPortCHpd = true register DdiPortDHpd = true - register "DdiPortFHpd" = "1" + register DdiPortFHpd = true # Enable DDC for DDI ports B/C register "DdiPortBDdc" = "1" register "DdiPortCDdc" = "1" diff --git a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb index 1915879..48a6a19 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb +++ b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb @@ -8,7 +8,7 @@ register DdiPortBHpd = true register DdiPortCHpd = true register DdiPortDHpd = true - register "DdiPortFHpd" = "1" + register DdiPortFHpd = true # Enable DDC for DDI ports B/C/D/F register "DdiPortBDdc" = "1" register "DdiPortCDdc" = "1"