Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31638
Change subject: device/pci_ids: Add Comet Lake U SA 2+2 Device ID ......................................................................
device/pci_ids: Add Comet Lake U SA 2+2 Device ID
Change-Id: I2e882a560dd0a1e96d6e1405735c6f7389c0db5a Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/include/device/pci_ids.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/31638/1
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 3046031..90b02cb 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3085,6 +3085,7 @@ #define PCI_DEVICE_ID_INTEL_ICL_ID_Y 0x8A10 #define PCI_DEVICE_ID_INTEL_ICL_ID_Y_2 0x8A00 #define PCI_DEVICE_ID_INTEL_CML_ULT 0x9B61 +#define PCI_DEVICE_ID_INTEL_CML_ULT_2_2 0x9B71 #define PCI_DEVICE_ID_INTEL_CML_ULT_6_2 0x9B51 #define PCI_DEVICE_ID_INTEL_CML_ULX 0x9B60 #define PCI_DEVICE_ID_INTEL_CML_S 0x9B55
Hello Aaron Durbin, Ronak Kanabar, Aamir Bohra, Duncan Laurie, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31638
to look at the new patch set (#2).
Change subject: device/pci_ids: Add Comet Lake U SA 2+2 Device ID ......................................................................
device/pci_ids: Add Comet Lake U SA 2+2 Device ID
This patch adds CML-U 2+2 SA DID into systemagent.c and report platform.
Change-Id: I2e882a560dd0a1e96d6e1405735c6f7389c0db5a Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/include/device/pci_ids.h M src/soc/intel/cannonlake/bootblock/report_platform.c M src/soc/intel/common/block/systemagent/systemagent.c 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/31638/2
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31638 )
Change subject: device/pci_ids: Add Comet Lake U SA 2+2 Device ID ......................................................................
Patch Set 2: Code-Review+1
Hello Patrick Rudolph, Aaron Durbin, Ronak Kanabar, Aamir Bohra, Duncan Laurie, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31638
to look at the new patch set (#3).
Change subject: soc/intel/cannonlake: Add Comet Lake U SA 2+2 Device ID ......................................................................
soc/intel/cannonlake: Add Comet Lake U SA 2+2 Device ID
This patch adds CML-U 2+2 SA DID into systemagent.c and report platform.
Change-Id: I2e882a560dd0a1e96d6e1405735c6f7389c0db5a Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/include/device/pci_ids.h M src/soc/intel/cannonlake/bootblock/report_platform.c M src/soc/intel/common/block/systemagent/systemagent.c 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/31638/3
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31638 )
Change subject: soc/intel/cannonlake: Add Comet Lake U SA 2+2 Device ID ......................................................................
Patch Set 3: Code-Review+2
Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31638 )
Change subject: soc/intel/cannonlake: Add Comet Lake U SA 2+2 Device ID ......................................................................
soc/intel/cannonlake: Add Comet Lake U SA 2+2 Device ID
This patch adds CML-U 2+2 SA DID into systemagent.c and report platform.
Change-Id: I2e882a560dd0a1e96d6e1405735c6f7389c0db5a Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/31638 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Ronak Kanabar ronak.kanabar@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/device/pci_ids.h M src/soc/intel/cannonlake/bootblock/report_platform.c M src/soc/intel/common/block/systemagent/systemagent.c 3 files changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Ronak Kanabar: Looks good to me, but someone else must approve
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 3046031..90b02cb 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3085,6 +3085,7 @@ #define PCI_DEVICE_ID_INTEL_ICL_ID_Y 0x8A10 #define PCI_DEVICE_ID_INTEL_ICL_ID_Y_2 0x8A00 #define PCI_DEVICE_ID_INTEL_CML_ULT 0x9B61 +#define PCI_DEVICE_ID_INTEL_CML_ULT_2_2 0x9B71 #define PCI_DEVICE_ID_INTEL_CML_ULT_6_2 0x9B51 #define PCI_DEVICE_ID_INTEL_CML_ULX 0x9B60 #define PCI_DEVICE_ID_INTEL_CML_S 0x9B55 diff --git a/src/soc/intel/cannonlake/bootblock/report_platform.c b/src/soc/intel/cannonlake/bootblock/report_platform.c index 1c239ab..41cfad6 100644 --- a/src/soc/intel/cannonlake/bootblock/report_platform.c +++ b/src/soc/intel/cannonlake/bootblock/report_platform.c @@ -58,6 +58,7 @@ { PCI_DEVICE_ID_INTEL_CFL_ID_H, "Coffeelake-H" }, { PCI_DEVICE_ID_INTEL_CFL_ID_S, "Coffeelake-S" }, { PCI_DEVICE_ID_INTEL_CML_ULT, "CometLake-U (4+2)" }, + { PCI_DEVICE_ID_INTEL_CML_ULT_2_2, "CometLake-U (2+2)" }, { PCI_DEVICE_ID_INTEL_CML_ULT_6_2, "CometLake-U (6+2)" }, { PCI_DEVICE_ID_INTEL_CML_ULX, "CometLake-ULX (4+2)" }, { PCI_DEVICE_ID_INTEL_CML_S, "CometLake-S (6+2)" }, diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c index 69c1232..4b4e74c 100644 --- a/src/soc/intel/common/block/systemagent/systemagent.c +++ b/src/soc/intel/common/block/systemagent/systemagent.c @@ -323,6 +323,7 @@ PCI_DEVICE_ID_INTEL_ICL_ID_Y, PCI_DEVICE_ID_INTEL_ICL_ID_Y_2, PCI_DEVICE_ID_INTEL_CML_ULT, + PCI_DEVICE_ID_INTEL_CML_ULT_2_2, PCI_DEVICE_ID_INTEL_CML_ULT_6_2, PCI_DEVICE_ID_INTEL_CML_ULX, PCI_DEVICE_ID_INTEL_CML_S,
-
Furquan Shaikh (Code Review) -
Ronak Kanabar (Code Review)
-
Subrata Banik (Code Review)