Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43850 )
Change subject: soc/intel/tigerlake: Invoke PCIe root port swapping
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43850/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43850/1//COMMIT_MSG@11
PS1, Line 11:
Please summarize the problem, this solves.
https://review.coreboot.org/c/coreboot/+/43850/1/src/soc/intel/tigerlake/chi...
File src/soc/intel/tigerlake/chip.c:
https://review.coreboot.org/c/coreboot/+/43850/1/src/soc/intel/tigerlake/chi...
PS1, Line 21:
Please use a space. (Unless clang-format wants to use a tab.)
https://review.coreboot.org/c/coreboot/+/43850/1/src/soc/intel/tigerlake/chi...
PS1, Line 150: swap
Swap
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43850
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9230de8b1818f3f2115dab923841fd0e7778be62
Gerrit-Change-Number: 43850
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 26 Jul 2020 05:54:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment