Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61632 )
Change subject: nb/amd/pi/00730F01/iommu: call pci_dev_set_resources directly ......................................................................
nb/amd/pi/00730F01/iommu: call pci_dev_set_resources directly
There is no need to have the iommu_set_resources function which only calls pci_dev_set_resources, so assign pci_dev_set_resources directly to the set_resources function pointer field in the iommu_ops struct.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I59c20e61a36fcc11b59d786139b4745ff662e560 Reviewed-on: https://review.coreboot.org/c/coreboot/+/61632 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org --- M src/northbridge/amd/pi/00730F01/iommu.c 1 file changed, 1 insertion(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/src/northbridge/amd/pi/00730F01/iommu.c b/src/northbridge/amd/pi/00730F01/iommu.c index c79ddb5..2de53d0 100644 --- a/src/northbridge/amd/pi/00730F01/iommu.c +++ b/src/northbridge/amd/pi/00730F01/iommu.c @@ -21,14 +21,9 @@ res->flags = IORESOURCE_MEM; }
-static void iommu_set_resources(struct device *dev) -{ - pci_dev_set_resources(dev); -} - static struct device_operations iommu_ops = { .read_resources = iommu_read_resources, - .set_resources = iommu_set_resources, + .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .ops_pci = &pci_dev_ops_pci, };
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.