Change in coreboot[master]: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus device

List overview All Threads
Download

newer

older

Change in coreboot[master]: build:...

Change in coreboot[master]:...

shkim (Code Review)

2 Oct 2019 2 Oct '19

2:49 a.m.

shkim has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35748 )

Change subject: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus device ......................................................................

mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus device

Applying reset_gpio config of stylus for kohaku. GPP_A19 has been assigned in latest schematics.

BUG=b:141914474 BRANCH=none TEST=verified stylus works internally Signed-off-by: Seunghwan Kim sh_.kim@samsung.com

Change-Id: I61f0f9a4378f47bf455f0726d44beeaf2f67197b --- M src/mainboard/google/hatch/variants/kohaku/gpio.c M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 2 files changed, 6 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/35748/1

diff --git a/src/mainboard/google/hatch/variants/kohaku/gpio.c b/src/mainboard/google/hatch/variants/kohaku/gpio.c index 9654388..84270b3 100644 --- a/src/mainboard/google/hatch/variants/kohaku/gpio.c +++ b/src/mainboard/google/hatch/variants/kohaku/gpio.c @@ -23,16 +23,16 @@ PAD_NC(GPP_A0, NONE), /* A6 : SERIRQ ==> NC */ PAD_NC(GPP_A6, NONE), - /* A10 : PEN_RESET_ODL */ - PAD_CFG_GPO(GPP_A10, 1, DEEP), + /* A10 : CLKOUT_LPC1 ==> NC */ + PAD_NC(GPP_A10, NONE), /* A16 : EMR_GARAGE_DET (notification) */ PAD_CFG_GPI_GPIO_DRIVER(GPP_A16, NONE, PLTRST), /* A17 : PIRQA# ==> NC */ PAD_NC(GPP_A17, NONE), /* A18 : ISH_GP0 ==> NC */ PAD_NC(GPP_A18, NONE), - /* A19 : ISH_GP1 ==> NC */ - PAD_NC(GPP_A19, NONE), + /* A19 : PEN_RESET_ODL */ + PAD_CFG_GPO(GPP_A19, 0, DEEP), /* A20 : ISH_GP2 ==> NC */ PAD_NC(GPP_A20, NONE), /* A22 : ISH_GP4 ==> NC */ diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index 8c7bb1f..37914fa 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -189,10 +189,8 @@ register "generic.desc" = ""WCOM Digitizer"" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C15)" - # TODO: We can't use GPP_A10 as reset_gpio due to its voltage level, - # so we need to reassign it or remove it. - #register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A10)" - #register "generic.reset_delay_ms" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A19)" + register "generic.reset_delay_ms" = "1" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x1" device i2c 0x09 on end

Attachments:

attachment.htm (text/html — 5.1 KB)

Show replies by date

shkim (Code Review)

2 Oct 2 Oct

2:51 a.m.

New subject: Change in coreboot[master]: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

Hello Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35748

to look at the new patch set (#2).

Change subject: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus ......................................................................

mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

Applying reset_gpio config of stylus for kohaku. GPP_A19 has been assigned in the latest schematics.

BUG=b:141914474 BRANCH=none TEST=verified stylus works internally Signed-off-by: Seunghwan Kim sh_.kim@samsung.com

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/35748/2

Shelley Chen (Code Review)

5:39 a.m.

New subject: Change in coreboot[master]: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35748 )

Change subject: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61f0f9a4378f47bf455f0726d44beeaf2f67197b Gerrit-Change-Number: 35748 Gerrit-PatchSet: 2 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: shkim sh_.kim@samsung.com Gerrit-Comment-Date: Wed, 02 Oct 2019 05:39:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Shelley Chen (Code Review)

6:04 a.m.

New subject: Change in coreboot[master]: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35748 )

Change subject: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus ......................................................................

Patch Set 2: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/35748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61f0f9a4378f47bf455f0726d44beeaf2f67197b Gerrit-Change-Number: 35748 Gerrit-PatchSet: 2 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: shkim sh_.kim@samsung.com Gerrit-Comment-Date: Wed, 02 Oct 2019 06:04:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

3 Oct 3 Oct

1:07 a.m.

New subject: Change in coreboot[master]: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35748 )

Change subject: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35748/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:

https://review.coreboot.org/c/coreboot/+/35748/2/src/mainboard/google/hatch/... PS2, Line 26: /* A10 : CLKOUT_LPC1 ==> NC */

...

Comment removed by: Patrick Georgi

There is a concern that we'll break some older devices if we update them with this change. Maybe we can keep GPP_A10 as an output gpio because that's what they expect?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61f0f9a4378f47bf455f0726d44beeaf2f67197b Gerrit-Change-Number: 35748 Gerrit-PatchSet: 2 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: shkim sh_.kim@samsung.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Thu, 03 Oct 2019 01:07:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen shchen@google.com Gerrit-MessageType: comment

SH Kim (Code Review)

4 Oct 4 Oct

12:40 a.m.

New subject: Change in coreboot[master]: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35748 )

Change subject: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35748/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:

https://review.coreboot.org/c/coreboot/+/35748/2/src/mainboard/google/hatch/... PS2, Line 26: /* A10 : CLKOUT_LPC1 ==> NC */

...

There is a concern that we'll break some older devices if we update them with this change. […]

There is an issue reset_gpio doesn't works on evt and older devices (operation voltage issue, b:137326841). Do you want to just keep GPP_A10 to output high for them? Or we can have another gpio override table for evt and older systems and use it for (board_id <= 3).

-- To view, visit https://review.coreboot.org/c/coreboot/+/35748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61f0f9a4378f47bf455f0726d44beeaf2f67197b Gerrit-Change-Number: 35748 Gerrit-PatchSet: 2 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: shkim sh_.kim@samsung.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Comment-Date: Fri, 04 Oct 2019 00:40:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen shchen@google.com Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Shelley Chen (Code Review)

5:46 a.m.

New subject: Change in coreboot[master]: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35748 )

Change subject: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35748/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:

https://review.coreboot.org/c/coreboot/+/35748/2/src/mainboard/google/hatch/... PS2, Line 26: /* A10 : CLKOUT_LPC1 ==> NC */

...

There is an issue reset_gpio doesn't works on evt and older devices (operation voltage issue, b:1373 […]

Yes, just leave GPP_A10 as output high. The reset gpio was never working for older devices anyway, so I think that that's ok.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61f0f9a4378f47bf455f0726d44beeaf2f67197b Gerrit-Change-Number: 35748 Gerrit-PatchSet: 2 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: shkim sh_.kim@samsung.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Comment-Date: Fri, 04 Oct 2019 05:46:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: SH Kim sh_.kim@samsung.corp-partner.google.com Comment-In-Reply-To: Shelley Chen shchen@google.com Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

SH Kim (Code Review)

6:09 a.m.

New subject: Change in coreboot[master]: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

SH Kim has uploaded a new patch set (#3) to the change originally created by shkim. ( https://review.coreboot.org/c/coreboot/+/35748 )

Change subject: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus ......................................................................

mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

Applying reset_gpio config of stylus for kohaku. GPP_A19 has been assigned in the latest schematics.

BUG=b:141914474 BRANCH=none TEST=verified stylus works internally Signed-off-by: Seunghwan Kim sh_.kim@samsung.com

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/35748/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/35748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61f0f9a4378f47bf455f0726d44beeaf2f67197b Gerrit-Change-Number: 35748 Gerrit-PatchSet: 3 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: shkim sh_.kim@samsung.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-MessageType: newpatchset

SH Kim (Code Review)

6:11 a.m.

New subject: Change in coreboot[master]: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

SH Kim has uploaded a new patch set (#4) to the change originally created by shkim. ( https://review.coreboot.org/c/coreboot/+/35748 )

Change subject: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus ......................................................................

mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

Applying reset_gpio config of stylus for kohaku. GPP_A19 has been assigned in the latest schematics.

We would keep GPP_A10 as output high for old revision devices temporarily.

BUG=b:141914474 BRANCH=none TEST=verified stylus works internally Signed-off-by: Seunghwan Kim sh_.kim@samsung.com

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/35748/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/35748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61f0f9a4378f47bf455f0726d44beeaf2f67197b Gerrit-Change-Number: 35748 Gerrit-PatchSet: 4 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: shkim sh_.kim@samsung.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-MessageType: newpatchset

SH Kim (Code Review)

6:12 a.m.

New subject: Change in coreboot[master]: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35748 )

Change subject: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35748/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:

https://review.coreboot.org/c/coreboot/+/35748/2/src/mainboard/google/hatch/... PS2, Line 26: /* A10 : CLKOUT_LPC1 ==> NC */

...

Yes, just leave GPP_A10 as output high. […]

We may need change it to NC config in future for power saving.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61f0f9a4378f47bf455f0726d44beeaf2f67197b Gerrit-Change-Number: 35748 Gerrit-PatchSet: 4 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: shkim sh_.kim@samsung.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Comment-Date: Fri, 04 Oct 2019 06:12:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: SH Kim sh_.kim@samsung.corp-partner.google.com Comment-In-Reply-To: Shelley Chen shchen@google.com Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Shelley Chen (Code Review)

11:52 p.m.

New subject: Change in coreboot[master]: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35748 )

Change subject: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35748/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:

https://review.coreboot.org/c/coreboot/+/35748/2/src/mainboard/google/hatch/... PS2, Line 26: /* A10 : CLKOUT_LPC1 ==> NC */

...

We may need change it to NC config in future for power saving.

Yes, we definitely will update.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61f0f9a4378f47bf455f0726d44beeaf2f67197b Gerrit-Change-Number: 35748 Gerrit-PatchSet: 4 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: shkim sh_.kim@samsung.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Comment-Date: Fri, 04 Oct 2019 23:52:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: SH Kim sh_.kim@samsung.corp-partner.google.com Comment-In-Reply-To: Shelley Chen shchen@google.com Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Shelley Chen (Code Review)

11:53 p.m.

New subject: Change in coreboot[master]: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35748 )

Change subject: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61f0f9a4378f47bf455f0726d44beeaf2f67197b Gerrit-Change-Number: 35748 Gerrit-PatchSet: 4 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: shkim sh_.kim@samsung.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Comment-Date: Fri, 04 Oct 2019 23:53:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Shelley Chen (Code Review)

8 Oct 8 Oct

5:37 a.m.

New subject: Change in coreboot[master]: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35748 )

Change subject: mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus ......................................................................

mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus

Applying reset_gpio config of stylus for kohaku. GPP_A19 has been assigned in the latest schematics.

We would keep GPP_A10 as output high for old revision devices temporarily.

BUG=b:141914474 BRANCH=none TEST=verified stylus works internally Signed-off-by: Seunghwan Kim sh_.kim@samsung.com

Change-Id: I61f0f9a4378f47bf455f0726d44beeaf2f67197b Reviewed-on: https://review.coreboot.org/c/coreboot/+/35748 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Shelley Chen shchen@google.com --- M src/mainboard/google/hatch/variants/kohaku/gpio.c M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 2 files changed, 5 insertions(+), 7 deletions(-)

Approvals: build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/kohaku/gpio.c b/src/mainboard/google/hatch/variants/kohaku/gpio.c index 9654388..7bf9a0c 100644 --- a/src/mainboard/google/hatch/variants/kohaku/gpio.c +++ b/src/mainboard/google/hatch/variants/kohaku/gpio.c @@ -23,7 +23,7 @@ PAD_NC(GPP_A0, NONE), /* A6 : SERIRQ ==> NC */ PAD_NC(GPP_A6, NONE), - /* A10 : PEN_RESET_ODL */ + /* A10 : PEN_RESET_ODL for old revision devices */ PAD_CFG_GPO(GPP_A10, 1, DEEP), /* A16 : EMR_GARAGE_DET (notification) */ PAD_CFG_GPI_GPIO_DRIVER(GPP_A16, NONE, PLTRST), @@ -31,8 +31,8 @@ PAD_NC(GPP_A17, NONE), /* A18 : ISH_GP0 ==> NC */ PAD_NC(GPP_A18, NONE), - /* A19 : ISH_GP1 ==> NC */ - PAD_NC(GPP_A19, NONE), + /* A19 : PEN_RESET_ODL */ + PAD_CFG_GPO(GPP_A19, 0, DEEP), /* A20 : ISH_GP2 ==> NC */ PAD_NC(GPP_A20, NONE), /* A22 : ISH_GP4 ==> NC */ diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index 8c7bb1f..37914fa 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -189,10 +189,8 @@ register "generic.desc" = ""WCOM Digitizer"" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C15)" - # TODO: We can't use GPP_A10 as reset_gpio due to its voltage level, - # so we need to reassign it or remove it. - #register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A10)" - #register "generic.reset_delay_ms" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A19)" + register "generic.reset_delay_ms" = "1" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x1" device i2c 0x09 on end

-- To view, visit https://review.coreboot.org/c/coreboot/+/35748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61f0f9a4378f47bf455f0726d44beeaf2f67197b Gerrit-Change-Number: 35748 Gerrit-PatchSet: 5 Gerrit-Owner: shkim sh_.kim@samsung.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: shkim sh_.kim@samsung.com Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-MessageType: merged

1877

days inactive

1883

days old

coreboot-gerrit@coreboot.org

12 comments

4 participants

tags (0)

participants (4)

Patrick Georgi (Code Review)
SH Kim (Code Review)
Shelley Chen (Code Review)
shkim (Code Review)