Hello Kevin Chiu,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/44514
to review the following change.
Change subject: mb/google/zork: remove unused asl files for dirinboz ......................................................................
mb/google/zork: remove unused asl files for dirinboz
BUG=b:161579679 BRANCH=master TEST=1. emerge-zork coreboot chromeos-bootimage 2. power on proto board successfully
Change-Id: I713ac3a47c2d47035affb32e6c604b9af23aa90e Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- D src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/audio.asl D src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/mainboard.asl D src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/sleep.asl 3 files changed, 0 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/44514/1
diff --git a/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/audio.asl b/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/audio.asl deleted file mode 100644 index 900e36f..0000000 --- a/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/audio.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/audio.asl> diff --git a/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/sleep.asl b/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/sleep.asl deleted file mode 100644 index 8177a9d..0000000 --- a/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/sleep.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/sleep.asl>
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44514 )
Change subject: mb/google/zork: remove unused asl files for dirinboz ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44514 )
Change subject: mb/google/zork: remove unused asl files for dirinboz ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44514 )
Change subject: mb/google/zork: remove unused asl files for dirinboz ......................................................................
mb/google/zork: remove unused asl files for dirinboz
BUG=b:161579679 BRANCH=master TEST=1. emerge-zork coreboot chromeos-bootimage 2. power on proto board successfully
Change-Id: I713ac3a47c2d47035affb32e6c604b9af23aa90e Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44514 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- D src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/audio.asl D src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/mainboard.asl D src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/sleep.asl 3 files changed, 0 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/audio.asl b/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/audio.asl deleted file mode 100644 index 900e36f..0000000 --- a/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/audio.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/audio.asl> diff --git a/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/mainboard.asl b/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/mainboard.asl deleted file mode 100644 index a1161ed..0000000 --- a/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/mainboard.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/mainboard.asl> diff --git a/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/sleep.asl b/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/sleep.asl deleted file mode 100644 index 8177a9d..0000000 --- a/src/mainboard/google/zork/variants/dirinboz/include/variant/acpi/sleep.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/sleep.asl>
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Kevin Chiu (Code Review)
-
Patrick Georgi (Code Review)