Attention is currently required from: Angel Pons, Christian Walter, Maximilian Brune.
Lean Sheng Tan has posted comments on this change by Lean Sheng Tan. ( https://review.coreboot.org/c/coreboot/+/79021?usp=email )
Change subject: mb/prodrive/atlas: Remove the workaround for CLKREQ pins
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/prodrive/atlas/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/79021/comment/ff968669_8312be2b?usp... :
PS3, Line 75: mcfg->CpuPcieRpClockReqMsgEnable[2] = 0;
can you test if the ones for CPU are also still needed? wouldn't be surprised if they now magically […]
Didnt manage to test it... might need to revisit this in future.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79021?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icbab617428551accda66499b7c2a32b2fa8c1689
Gerrit-Change-Number: 79021
Gerrit-PatchSet: 3
Gerrit-Owner: Lean Sheng Tan
tanleansheng@outlook.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 26 Dec 2024 21:02:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com