Attention is currently required from: Jason Glenesk, Marshall Dawson, Jeremy Soller, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59103 )
Change subject: soc/amd/cezanne: enable LPC decodes if platform uses LPC ......................................................................
Patch Set 2:
(2 comments)
File src/soc/amd/cezanne/early_fch.c:
https://review.coreboot.org/c/coreboot/+/59103/comment/82909cd0_c6830306 PS2, Line 24: lpc_configure_decodes
I agree, and plan to do so since the EC decodes also have to be set up in the mainboard right now. […]
would be great to have that added later, but that's something for another patch. amd/mandolin sets this up in the bootblock of the mainboard code and i don't think any other mainboard using picasso or cezanne uses LPC, so that was just not implemented
https://review.coreboot.org/c/coreboot/+/59103/comment/1e9c1179_b058cc89 PS2, Line 50: if (!CONFIG(SOC_AMD_COMMON_BLOCK_USE_ESPI))
Should this be done here at this point? If so can you please capture the reason as a comment so that […]
would be good to move that in the same spot as in picasso which would be after the next if statement
-
Felix Held (Code Review)