Attention is currently required from: Patrick Rudolph, Lean Sheng Tan, David.Milosevic@9elements.com.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 )
Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ......................................................................
Patch Set 3:
(7 comments)
File src/mainboard/prodrive/atlas/emi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159859): https://review.coreboot.org/c/coreboot/+/68137/comment/502c7442_48263037 PS3, Line 51: switch (access) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159859): https://review.coreboot.org/c/coreboot/+/68137/comment/73831ee3_030fe9c8 PS3, Line 89: switch(access) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159859): https://review.coreboot.org/c/coreboot/+/68137/comment/7e4fb90c_30a9dad2 PS3, Line 89: switch(access) { space required before the open parenthesis '('
File src/mainboard/prodrive/atlas/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159859): https://review.coreboot.org/c/coreboot/+/68137/comment/4bee6da0_349416f0 PS3, Line 14: static const char* get_smbios_part_number(void); "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159859): https://review.coreboot.org/c/coreboot/+/68137/comment/cf51eec4_cbde6674 PS3, Line 41: static const char* get_smbios_part_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/smbios.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159859): https://review.coreboot.org/c/coreboot/+/68137/comment/25f145ce_fae68f10 PS3, Line 8: const char* smbios_mainboard_serial_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/vpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159859): https://review.coreboot.org/c/coreboot/+/68137/comment/169c4347_4ba162f3 PS3, Line 34: switch (vpd) { switch and case should be at the same indent