Change in coreboot[master]: mb/google/dedede/var/drawcia: Add FW_CONFIG probe for EXT_VR
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63075 )
Change subject: mb/google/dedede/var/drawcia: Add FW_CONFIG probe for EXT_VR ......................................................................
Patch Set 2:
(6 comments)
File src/mainboard/google/dedede/variants/drawcia/ramstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144626): https://review.coreboot.org/c/coreboot/+/63075/comment/1f2c6cf1_f8cf2193 PS2, Line 12: struct soc_intel_jasperlake_config *cfg = config_of_soc(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144626): https://review.coreboot.org/c/coreboot/+/63075/comment/8d44a7bd_565c1143 PS2, Line 12: struct soc_intel_jasperlake_config *cfg = config_of_soc(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144626): https://review.coreboot.org/c/coreboot/+/63075/comment/aa46fdda_de25fca1 PS2, Line 14: if (fw_config_probe(FW_CONFIG(EXT_VR, EXT_VR_ABSENT))) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144626): https://review.coreboot.org/c/coreboot/+/63075/comment/4890f668_70ec3572 PS2, Line 14: if (fw_config_probe(FW_CONFIG(EXT_VR, EXT_VR_ABSENT))) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144626): https://review.coreboot.org/c/coreboot/+/63075/comment/48e7c461_b6c2a09f PS2, Line 15: cfg->disable_external_bypass_vr = 1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144626): https://review.coreboot.org/c/coreboot/+/63075/comment/17d6ba80_30e9effc PS2, Line 15: cfg->disable_external_bypass_vr = 1; please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)