Attention is currently required from: Saurabh Mishra.
Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83732?usp=email )
Change subject: vc/intel/fsp2_0: Add Skeleton FSP header for PTL ......................................................................
Patch Set 4:
(7 comments)
Patchset:
PS4: s
Commit Message:
https://review.coreboot.org/c/coreboot/+/83732/comment/bee804fb_ceb4b48e?usp... : PS4, Line 7: vc/intel/fsp2_0 ``` vc/intel/fsp/fsp2_0/ptl: Add placeholder FSP headers to compile
```
Specify that this is dummy header files requires to compile the PTL SoC and mainboard code
File src/vendorcode/intel/fsp/fsp2_0/pantherlake/FirmwareVersionInfo.h:
https://review.coreboot.org/c/coreboot/+/83732/comment/2c6a0808_f9233843?usp... : PS4, Line 1: /** @file : Intel Firmware Version Info (FVI) related definitions. : : @todo update document/spec reference : : Copyright (c) 2016, Intel Corporation. All rights reserved.<BR> : SPDX-License-Identifier: BSD-2-Clause-Patent : : @par Specification Reference: : System Management BIOS (SMBIOS) Reference Specification v3.0.0 dated 2015-Feb-12 : http://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.0.0.pd... : : **/ please use open source applicable copyright header
File src/vendorcode/intel/fsp/fsp2_0/pantherlake/FspProducerDataHeader.h:
https://review.coreboot.org/c/coreboot/+/83732/comment/c47cd5a1_74f85937?usp... : PS4, Line 13: @copyright : INTEL CONFIDENTIAL : Copyright (C) 2023 Intel Corporation. : : This software and the related documents are Intel copyrighted materials, : and your use of them is governed by the express license under which they : were provided to you ("License"). Unless the License provides otherwise, : you may not use, modify, copy, publish, distribute, disclose or transmit : this software or the related documents without Intel's prior written : permission. : : This software and the related documents are provided as is, with no : express or implied warranties, other than those that are expressly stated : in the License. same
File src/vendorcode/intel/fsp/fsp2_0/pantherlake/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/83732/comment/b9bded4b_ea7a4776?usp... : PS4, Line 46: why empty lines?
File src/vendorcode/intel/fsp/fsp2_0/pantherlake/FspsUpd.h:
https://review.coreboot.org/c/coreboot/+/83732/comment/1566030d_766a6f83?usp... : PS4, Line 64: same as FSP-M
File src/vendorcode/intel/fsp/fsp2_0/pantherlake/MemInfoHob.h:
https://review.coreboot.org/c/coreboot/+/83732/comment/7f954436_f93cc33c?usp... : PS4, Line 1: /** @file : This file contains definitions required for creation of : Memory S3 Save data, Memory Info data and Memory Platform : data hobs. : : @copyright : INTEL CONFIDENTIAL : Copyright (C) 1999 Intel Corporation. : : This software and the related documents are Intel copyrighted materials, : and your use of them is governed by the express license under which they : were provided to you ("License"). Unless the License provides otherwise, : you may not use, modify, copy, publish, distribute, disclose or transmit : this software or the related documents without Intel's prior written : permission. : : This software and the related documents are provided as is, with no : express or implied warranties, other than those that are expressly stated : in the License. : : @par Specification Reference: : **/ Please follow the correct copyright format for open source code. You can't push Intel Confidential header in GPL
-
Subrata Banik (Code Review)