Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth, Stefan Reinauer, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75707?usp=email )
Change subject: Rename CBFS master header -> CBFS main header
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75707/comment/0e9ab1e6_69502039 :
PS5, Line 9: Calling it the main header is more descriptive of its pupose
: and should therefore be preferred.
Your opinion on this is noted. […]
How about calling it "CBFS legacy header" to indicate that it is old and deprecated (although for practical purposes of compatibility with old payloads, I'm not sure if we'll ever really want to remove it)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75707?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I624da280dd78d707b96897b84768be5f5baf0770
Gerrit-Change-Number: 75707
Gerrit-PatchSet: 7
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 19:34:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-MessageType: comment