Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81865?usp=email )
Change subject: mb/amd/*: Increase SMMSTORE size to 256K ......................................................................
mb/amd/*: Increase SMMSTORE size to 256K
Anything below 128K will cause SMMSTORE driver in edk2 to fail, since a minimum of (2) 64K blocks are needed. Increase the size to 256K to match other boards in the tree.
Change-Id: I04d57ff7f74d79118652cfe227cf223375df6472 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/81865 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/amd/birman/chromeos_glinda.fmd M src/mainboard/amd/birman/chromeos_phoenix.fmd M src/mainboard/amd/birman_plus/chromeos_glinda.fmd M src/mainboard/amd/birman_plus/chromeos_phoenix.fmd M src/mainboard/amd/chausie/chromeos.fmd M src/mainboard/amd/majolica/chromeos.fmd M src/mainboard/amd/mayan/chromeos.fmd 7 files changed, 7 insertions(+), 7 deletions(-)
Approvals: Felix Held: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/amd/birman/chromeos_glinda.fmd b/src/mainboard/amd/birman/chromeos_glinda.fmd index 843a026..66227c2 100644 --- a/src/mainboard/amd/birman/chromeos_glinda.fmd +++ b/src/mainboard/amd/birman/chromeos_glinda.fmd @@ -27,7 +27,7 @@ } RW_VPD(PRESERVE) 8K RW_NVRAM(PRESERVE) 20K - SMMSTORE(PRESERVE) 64K + SMMSTORE(PRESERVE) 256K RW_LEGACY(CBFS) EC_BODY@15872K 256K RW_MRC_CACHE(PRESERVE) 120K diff --git a/src/mainboard/amd/birman/chromeos_phoenix.fmd b/src/mainboard/amd/birman/chromeos_phoenix.fmd index 9d6d402..420ed6e 100644 --- a/src/mainboard/amd/birman/chromeos_phoenix.fmd +++ b/src/mainboard/amd/birman/chromeos_phoenix.fmd @@ -27,7 +27,7 @@ } RW_VPD(PRESERVE) 8K RW_NVRAM(PRESERVE) 20K - SMMSTORE(PRESERVE) 64K + SMMSTORE(PRESERVE) 256K RW_LEGACY(CBFS) EC_BODY@15872K 256K RW_MRC_CACHE(PRESERVE) 256K diff --git a/src/mainboard/amd/birman_plus/chromeos_glinda.fmd b/src/mainboard/amd/birman_plus/chromeos_glinda.fmd index 843a026..66227c2 100644 --- a/src/mainboard/amd/birman_plus/chromeos_glinda.fmd +++ b/src/mainboard/amd/birman_plus/chromeos_glinda.fmd @@ -27,7 +27,7 @@ } RW_VPD(PRESERVE) 8K RW_NVRAM(PRESERVE) 20K - SMMSTORE(PRESERVE) 64K + SMMSTORE(PRESERVE) 256K RW_LEGACY(CBFS) EC_BODY@15872K 256K RW_MRC_CACHE(PRESERVE) 120K diff --git a/src/mainboard/amd/birman_plus/chromeos_phoenix.fmd b/src/mainboard/amd/birman_plus/chromeos_phoenix.fmd index 9d6d402..420ed6e 100644 --- a/src/mainboard/amd/birman_plus/chromeos_phoenix.fmd +++ b/src/mainboard/amd/birman_plus/chromeos_phoenix.fmd @@ -27,7 +27,7 @@ } RW_VPD(PRESERVE) 8K RW_NVRAM(PRESERVE) 20K - SMMSTORE(PRESERVE) 64K + SMMSTORE(PRESERVE) 256K RW_LEGACY(CBFS) EC_BODY@15872K 256K RW_MRC_CACHE(PRESERVE) 256K diff --git a/src/mainboard/amd/chausie/chromeos.fmd b/src/mainboard/amd/chausie/chromeos.fmd index a27d5c3..c0e02dd 100644 --- a/src/mainboard/amd/chausie/chromeos.fmd +++ b/src/mainboard/amd/chausie/chromeos.fmd @@ -19,7 +19,7 @@ } RW_VPD(PRESERVE) 8K RW_NVRAM(PRESERVE) 20K - SMMSTORE(PRESERVE) 4K + SMMSTORE(PRESERVE) 256K RW_LEGACY(CBFS) WP_RO@10M 6M { RO_VPD(PRESERVE) 16K diff --git a/src/mainboard/amd/majolica/chromeos.fmd b/src/mainboard/amd/majolica/chromeos.fmd index bb21767..1a1d96b 100644 --- a/src/mainboard/amd/majolica/chromeos.fmd +++ b/src/mainboard/amd/majolica/chromeos.fmd @@ -19,7 +19,7 @@ } RW_VPD(PRESERVE) 8K RW_NVRAM(PRESERVE) 20K - SMMSTORE(PRESERVE) 4K + SMMSTORE(PRESERVE) 256K RW_LEGACY(CBFS) WP_RO@8M 8M { RO_VPD(PRESERVE) 16K diff --git a/src/mainboard/amd/mayan/chromeos.fmd b/src/mainboard/amd/mayan/chromeos.fmd index dca61fc..b70d561 100644 --- a/src/mainboard/amd/mayan/chromeos.fmd +++ b/src/mainboard/amd/mayan/chromeos.fmd @@ -27,7 +27,7 @@ } RW_VPD(PRESERVE) 8K RW_NVRAM(PRESERVE) 20K - SMMSTORE(PRESERVE) 64K + SMMSTORE(PRESERVE) 256K RW_LEGACY(CBFS) RW_MRC_CACHE(PRESERVE) 256K }
-
Felix Held (Code Review)