Change in coreboot[master]: device/pci_device.c: Use same indents for switch/case

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Felix Singer (Code Review)

6 Jan 2021 6 Jan '21

10:16 p.m.

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49205 )

Change subject: device/pci_device.c: Use same indents for switch/case ......................................................................

device/pci_device.c: Use same indents for switch/case

Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/device/pci_device.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/49205/1

diff --git a/src/device/pci_device.c b/src/device/pci_device.c index a7eb91d..f41689e 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -967,7 +967,7 @@ dev->ops = &default_cardbus_ops_bus; break; #endif -default: + default: bad: if (dev->enabled) { printk(BIOS_ERR, "%s [%04x/%04x/%06x] has unknown "

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

Felix Singer (Code Review)

6 Jan 6 Jan

10:17 p.m.

Felix Singer has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/49205 )

Change subject: device/pci_device.c: Use same indents for switch/case ......................................................................

device/pci_device.c: Use same indents for switch/case

Use same indents for switch/case to fix linter issues.

Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/device/pci_device.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/49205/2

Felix Singer (Code Review)

10:32 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49205

to look at the new patch set (#3).

Change subject: device/pci_device.c: Use same indents for switch/case ......................................................................

device/pci_device.c: Use same indents for switch/case

Use same indents for switch/case to fix linter issues.

Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/device/pci_device.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/49205/3

Angel Pons (Code Review)

7 Jan 7 Jan

8:13 a.m.

Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49205 )

Change subject: device/pci_device.c: Use same indents for switch/case ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/49205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Gerrit-Change-Number: 49205 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Comment-Date: Thu, 07 Jan 2021 16:13:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

12:52 p.m.

Attention is currently required from: Felix Singer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49205 )

Change subject: device/pci_device.c: Use same indents for switch/case ......................................................................

Patch Set 3:

(1 comment)

File src/device/pci_device.c:

https://review.coreboot.org/c/coreboot/+/49205/comment/ee804cf8_9e3ad527 PS3, Line 970: default: : bad: I can pretty much imagine why the author did it like this. How about indenting the `bad:` too? or is there a linter against it?

-- To view, visit https://review.coreboot.org/c/coreboot/+/49205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Gerrit-Change-Number: 49205 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Comment-Date: Thu, 07 Jan 2021 20:52:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

1:08 p.m.

Attention is currently required from: Felix Singer, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49205 )

Change subject: device/pci_device.c: Use same indents for switch/case ......................................................................

Patch Set 3:

(1 comment)

File src/device/pci_device.c:

https://review.coreboot.org/c/coreboot/+/49205/comment/886a85a3_acb2fee4 PS3, Line 970: default: : bad:

...

I can pretty much imagine why the author did it like this. How about […]

CB:772

Coding style doesn't say anything in particular. Personally, I prefer not to indent goto labels for clarity, especially when interleaved within a switch/case statement.

-- To view, visit https://review.coreboot.org/c/coreboot/+/49205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Gerrit-Change-Number: 49205 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Thu, 07 Jan 2021 21:08:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Nico Huber (Code Review)

1:14 p.m.

Attention is currently required from: Felix Singer. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49205 )

Change subject: device/pci_device.c: Use same indents for switch/case ......................................................................

Patch Set 3:

(1 comment)

File src/device/pci_device.c:

https://review.coreboot.org/c/coreboot/+/49205/comment/95552757_3d88a716 PS3, Line 970: default: : bad:

...

CB:772 […]

I would not call this interleaved, though. It's fully contained in the switch/case statement.

Maybe `goto default;` would work?

-- To view, visit https://review.coreboot.org/c/coreboot/+/49205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Gerrit-Change-Number: 49205 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Comment-Date: Thu, 07 Jan 2021 21:14:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

2:31 p.m.

Attention is currently required from: Felix Singer, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49205 )

Change subject: device/pci_device.c: Use same indents for switch/case ......................................................................

Patch Set 3:

(1 comment)

File src/device/pci_device.c:

https://review.coreboot.org/c/coreboot/+/49205/comment/da9daf40_ed107745 PS3, Line 970: default: : bad:

...

I would not call this interleaved, though. It's fully contained in the […]

I don't think you can use goto with case labels. Something that would work:

#if CONFIG(CARDBUS_PLUGIN_SUPPORT) case PCI_HEADER_TYPE_CARDBUS: dev->ops = &default_cardbus_ops_bus; break; #endif default: goto bad; }

return;

bad: if (dev->enabled) { printk(BIOS_ERR, "%s [%04x/%04x/%06x] has unknown " "header type %02x, ignoring.\n", dev_path(dev), dev->vendor, dev->device, dev->class >> 8, dev->hdr_type); } }

-- To view, visit https://review.coreboot.org/c/coreboot/+/49205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Gerrit-Change-Number: 49205 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Thu, 07 Jan 2021 22:31:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Felix Singer (Code Review)

9 Jan 9 Jan

7:10 a.m.

Attention is currently required from: Felix Singer, Nico Huber. Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49205

to look at the new patch set (#7).

Change subject: device/pci_device.c: Use same indents for switch/case ......................................................................

device/pci_device.c: Use same indents for switch/case

Use same indents for switch/case to fix linter issues.

Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/device/pci_device.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/49205/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/49205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Gerrit-Change-Number: 49205 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

8:22 a.m.

Attention is currently required from: Felix Singer, Nico Huber. Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49205

to look at the new patch set (#8).

Change subject: device/pci_device.c: Use same indents for switch/case ......................................................................

device/pci_device.c: Use same indents for switch/case

Use same indents for switch/case to fix linter issues.

Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/device/pci_device.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/49205/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/49205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Gerrit-Change-Number: 49205 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

8:23 a.m.

Attention is currently required from: Felix Singer, Nico Huber. Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49205

to look at the new patch set (#9).

Change subject: device/pci_device.c: Use same indents for switch/case ......................................................................

device/pci_device.c: Use same indents for switch/case

Use same indents for switch/case to fix linter issues.

Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/device/pci_device.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/49205/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/49205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Gerrit-Change-Number: 49205 Gerrit-PatchSet: 9 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Attention: Felix Singer felixsinger@posteo.net Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

12 Jan 12 Jan

5:34 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49205 )

Change subject: device/pci_device.c: Use same indents for switch/case ......................................................................

device/pci_device.c: Use same indents for switch/case

Use same indents for switch/case to fix linter issues.

Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/49205 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/device/pci_device.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/49205 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c6abf5b918bac3df8d7617824392f2ec932cb32 Gerrit-Change-Number: 49205 Gerrit-PatchSet: 10 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-MessageType: merged

1479

days inactive

1484

days old

coreboot-gerrit@coreboot.org

11 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Felix Singer (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)