Change in coreboot[master]: mb/lenovo/{t60,z61t}: whitespace

[Peter Lemenkov (Code Review)]

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34122 )

Change subject: mb/lenovo/{t60,z61t}: whitespace
......................................................................

mb/lenovo/{t60,z61t}: whitespace

This just makes diff between these two boards smaller.

Change-Id: Id2d602b0a6d2bd07202d8a4d81ee42da8388ef7e
Signed-off-by: Peter Lemenkov 
---
M src/mainboard/lenovo/t60/cmos.layout
M src/mainboard/lenovo/t60/hda_verb.c
M src/mainboard/lenovo/z61t/romstage.c
M src/mainboard/lenovo/z61t/smihandler.c
4 files changed, 11 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/34122/1

diff --git a/src/mainboard/lenovo/t60/cmos.layout b/src/mainboard/lenovo/t60/cmos.layout
index d7ff0f2..75ad427 100644
--- a/src/mainboard/lenovo/t60/cmos.layout
+++ b/src/mainboard/lenovo/t60/cmos.layout
@@ -48,7 +48,6 @@

# -----------------------------------------------------------------
 # coreboot config options: console
-#392          3       r       0        unused
 395          4       e       6        debug_level
 #399          1       r       0        unused

diff --git a/src/mainboard/lenovo/t60/hda_verb.c b/src/mainboard/lenovo/t60/hda_verb.c
index 3507776..73eecf6 100644
--- a/src/mainboard/lenovo/t60/hda_verb.c
+++ b/src/mainboard/lenovo/t60/hda_verb.c
@@ -1,9 +1,12 @@
 /*
  * This file is part of the coreboot project.
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
+ * Copyright (C) 2007-2009 coresystems GmbH
+ *               2012 secunet Security Networks AG
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; version 2 of the License.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
diff --git a/src/mainboard/lenovo/z61t/romstage.c b/src/mainboard/lenovo/z61t/romstage.c
index 716be16..820cd52 100644
--- a/src/mainboard/lenovo/z61t/romstage.c
+++ b/src/mainboard/lenovo/z61t/romstage.c
@@ -41,9 +41,9 @@
    // decode range
    pci_write_config16(PCI_DEV(0, 0x1f, 0), LPC_IO_DEC, 0x0210);
    // decode range
-	pci_write_config16(PCI_DEV(0, 0x1f, 0), LPC_EN, CNF1_LPC_EN
-			| MC_LPC_EN | KBC_LPC_EN | GAMEH_LPC_EN | GAMEL_LPC_EN
-			| FDD_LPC_EN | LPT_LPC_EN | COMA_LPC_EN);
+	pci_write_config16(PCI_DEV(0, 0x1f, 0), LPC_EN, CNF1_LPC_EN | MC_LPC_EN
+			| KBC_LPC_EN | GAMEH_LPC_EN | GAMEL_LPC_EN | FDD_LPC_EN
+			| LPT_LPC_EN | COMA_LPC_EN);

/* range 0x1600 - 0x167f */
    pci_write_config32(PCI_DEV(0, 0x1f, 0), GEN1_DEC, 0x007c1601);
diff --git a/src/mainboard/lenovo/z61t/smihandler.c b/src/mainboard/lenovo/z61t/smihandler.c
index eacbd5e..51ced89 100644
--- a/src/mainboard/lenovo/z61t/smihandler.c
+++ b/src/mainboard/lenovo/z61t/smihandler.c
@@ -39,8 +39,7 @@
 {
    u8 *bar;
    if ((bar = (u8 *)pci_read_config32(PCI_DEV(1, 0, 0), 0x18))) {
-		printk(BIOS_DEBUG, "bar: %08X, level %02X\n",  (unsigned int)bar,
-			*(bar+LVTMA_BL_MOD_LEVEL));
+		printk(BIOS_DEBUG, "bar: %08X, level %02X\n",  (unsigned int)bar, *(bar+LVTMA_BL_MOD_LEVEL));
    	*(bar+LVTMA_BL_MOD_LEVEL) &= 0xf0;
    	if (*(bar+LVTMA_BL_MOD_LEVEL) > 0x10)
    		*(bar+LVTMA_BL_MOD_LEVEL) -= 0x10;
@@ -51,8 +50,7 @@
 {
    u8 *bar;
    if ((bar = (u8 *)pci_read_config32(PCI_DEV(1, 0, 0), 0x18))) {
-		printk(BIOS_DEBUG, "bar: %08X, level %02X\n",  (unsigned int)bar,
-			*(bar+LVTMA_BL_MOD_LEVEL));
+		printk(BIOS_DEBUG, "bar: %08X, level %02X\n",  (unsigned int)bar, *(bar+LVTMA_BL_MOD_LEVEL));
    	*(bar+LVTMA_BL_MOD_LEVEL) |= 0x0f;
    	if (*(bar+LVTMA_BL_MOD_LEVEL) < 0xf0)
    		*(bar+LVTMA_BL_MOD_LEVEL) += 0x10;

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34122 )

Change subject: mb/lenovo/{t60,z61t}: whitespace
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34122/1/src/mainboard/lenovo/z61t/s... 
File src/mainboard/lenovo/z61t/smihandler.c:

https://review.coreboot.org/c/coreboot/+/34122/1/src/mainboard/lenovo/z61t/s... 
PS1, Line 42: 		printk(BIOS_DEBUG, "bar: %08X, level %02X\n",  (unsigned int)bar, *(bar+LVTMA_BL_MOD_LEVEL));
line over 96 characters

https://review.coreboot.org/c/coreboot/+/34122/1/src/mainboard/lenovo/z61t/s... 
PS1, Line 53: 		printk(BIOS_DEBUG, "bar: %08X, level %02X\n",  (unsigned int)bar, *(bar+LVTMA_BL_MOD_LEVEL));
line over 96 characters

Change in coreboot[master]: mb/lenovo/{t60,z61t}: whitespace and cosmetic

[Peter Lemenkov (Code Review)]

Hello Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34122

to look at the new patch set (#2).

Change subject: mb/lenovo/{t60,z61t}: whitespace and cosmetic
......................................................................

mb/lenovo/{t60,z61t}: whitespace and cosmetic

This just makes diff between these two boards smaller.

Change-Id: Id2d602b0a6d2bd07202d8a4d81ee42da8388ef7e
Signed-off-by: Peter Lemenkov 
---
M src/mainboard/lenovo/t60/cmos.layout
M src/mainboard/lenovo/t60/hda_verb.c
M src/mainboard/lenovo/z61t/romstage.c
M src/mainboard/lenovo/z61t/smihandler.c
4 files changed, 11 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/34122/2

Change in coreboot[master]: mb/lenovo/{t60,z61t}: whitespace and cosmetic

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34122 )

Change subject: mb/lenovo/{t60,z61t}: whitespace and cosmetic
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: mb/lenovo/{t60,z61t}: whitespace and cosmetic

[Alexander Couzens (Code Review)]

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34122 )

Change subject: mb/lenovo/{t60,z61t}: whitespace and cosmetic
......................................................................

Patch Set 2: Code-Review-1

(1 comment)

rest looks good, except the removal of the cmos.

https://review.coreboot.org/c/coreboot/+/34122/2/src/mainboard/lenovo/t60/cm... 
File src/mainboard/lenovo/t60/cmos.layout:

https://review.coreboot.org/c/coreboot/+/34122/2/src/mainboard/lenovo/t60/cm... 
PS2, Line 51: 
Please don't remove this line. It helps keeping the track of unsued bits. But you could add this line to the other board.

Change in coreboot[master]: mb/lenovo/{t60,z61t}: whitespace and cosmetic

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34122 )

Change subject: mb/lenovo/{t60,z61t}: whitespace and cosmetic
......................................................................

Patch Set 2: Code-Review-1

(1 comment)

If you're going to make these two boards use the variant mechanism, why bother withn this change?

https://review.coreboot.org/c/coreboot/+/34122/2/src/mainboard/lenovo/t60/hd... 
File src/mainboard/lenovo/t60/hda_verb.c:

https://review.coreboot.org/c/coreboot/+/34122/2/src/mainboard/lenovo/t60/hd... 
PS2, Line 3:  *
           :  * Copyright (C) 2007-2009 coresystems GmbH
           :  *               2012 secunet Security Networks AG
           :  *
Is this correct, though? This file was only touched by CB:6840, CB:16529 and CB:26568.

IANAL, but I don't think you can just add copyright lines to a file.

Change in coreboot[master]: mb/lenovo/{t60,z61t}: whitespace and cosmetic

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34122 )

Change subject: mb/lenovo/{t60,z61t}: whitespace and cosmetic
......................................................................

Patch Set 2:

Removing +2 to get this out of my list of changes to merge when there are 2 -1 comments.  Hopefully these will be addressed soon.

Change in coreboot[master]: mb/lenovo/{t60,z61t}: whitespace and cosmetic

[Martin Roth (Code Review)]

Martin Roth has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/34122 )

Change subject: mb/lenovo/{t60,z61t}: whitespace and cosmetic
......................................................................

Removed Code-Review+2 by Patrick Rudolph

Change in coreboot[master]: mb/lenovo/{t60,z61t}: whitespace and cosmetic

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34122 )

Change subject: mb/lenovo/{t60,z61t}: whitespace and cosmetic
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34122/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34122/2//COMMIT_MSG@7 
PS2, Line 7: mb/lenovo/{t60,z61t}: whitespace and cosmetic
           : 
           : This just makes diff between these two boards smaller.
Maybe:
> mb/lenovo/{t60,z61t}: Unify files
>
> This just makes diff between these two boards smaller by removing
> whitespace and cosmetic differences.

Change in coreboot[master]: mb/lenovo/{t60,z61t}: whitespace and cosmetic

[Peter Lemenkov (Code Review)]

Peter Lemenkov has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34122 )

Change subject: mb/lenovo/{t60,z61t}: whitespace and cosmetic
......................................................................

Abandoned

Abandoned this one and melted into the main commit.