Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49124 )
Change subject: mb/google/brya: Remove `Some generic macros` comment ......................................................................
mb/google/brya: Remove `Some generic macros` comment
This comment is useless, and was dropped from the tree in the past.
Change-Id: Ie46bf13ec27ff9cd9423795fc170cc7526e18122 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/brya/dsdt.asl 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/49124/1
diff --git a/src/mainboard/google/brya/dsdt.asl b/src/mainboard/google/brya/dsdt.asl index fcdd1a8..9a3afce 100644 --- a/src/mainboard/google/brya/dsdt.asl +++ b/src/mainboard/google/brya/dsdt.asl @@ -12,7 +12,6 @@ 0x20110725 // OEM revision ) { - /* Some generic macros */ #include <soc/intel/common/acpi/platform.asl>
/* global NVS and variables */
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49124
to look at the new patch set (#2).
Change subject: mb/google/brya: Remove `Some generic macros` comment ......................................................................
mb/google/brya: Remove `Some generic macros` comment
This comment is useless, and was dropped from the tree in the past.
Change-Id: Ie46bf13ec27ff9cd9423795fc170cc7526e18122 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/brya/dsdt.asl 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/49124/2
Attention is currently required from: Angel Pons. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49124 )
Change subject: mb/google/brya: Remove `Some generic macros` comment ......................................................................
Patch Set 2: Code-Review+1
Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49124 )
Change subject: mb/google/brya: Remove `Some generic macros` comment ......................................................................
Patch Set 2: Code-Review+2
Attention is currently required from: Angel Pons. Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49124 )
Change subject: mb/google/brya: Remove `Some generic macros` comment ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49124 )
Change subject: mb/google/brya: Remove `Some generic macros` comment ......................................................................
mb/google/brya: Remove `Some generic macros` comment
This comment is useless, and was dropped from the tree in the past.
Change-Id: Ie46bf13ec27ff9cd9423795fc170cc7526e18122 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49124 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Christian Walter christian.walter@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brya/dsdt.asl 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Christian Walter: Looks good to me, approved
diff --git a/src/mainboard/google/brya/dsdt.asl b/src/mainboard/google/brya/dsdt.asl index 3b50507f..5d386f1 100644 --- a/src/mainboard/google/brya/dsdt.asl +++ b/src/mainboard/google/brya/dsdt.asl @@ -13,7 +13,6 @@ ) { #include <acpi/dsdt_top.asl> - /* Some generic macros */ #include <soc/intel/common/acpi/platform.asl>
/* global NVS and variables */