Attention is currently required from: Bora Guvendik, Cliff Huang, Jérémy Compostella, Pranava Y N.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84901?usp=email )
Change subject: soc/intel/common/gpio: add function to lock GPIO configuration
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/84901/comment/70805255_ec6fa45c?usp... :
PS3, Line 485: /* Clear lock for the exception PADs */
Locked pads still function as it is configured, just that we won't be able to change the configuration afterwards (i.e. dp & OS). There is also TX state lock bit(s) in separate registers, but we don't consider locking those output for a selected GPOs.
my points is even w/o these two cls, when we have marked any PAD as lock config, we won't be able to change the PAD configuration post FSP_S, unless we are in SMM. I don't follow what value this CL is bringing?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84901?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iabe4e4b1d282a5f6cae8f330100c9139e0c2691d
Gerrit-Change-Number: 84901
Gerrit-PatchSet: 3
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 30 Oct 2024 18:00:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com