Attention is currently required from: Tarun Tuli, Michał Żygowski, Kangheui Won, Reka Norman, Rizwan Qureshi.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69324 )
Change subject: soc/intel/alderlake: Check MANUF_LOCK when logging manufacturing mode
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/me.c:
https://review.coreboot.org/c/coreboot/+/69324/comment/c7c0265e_8381777f
PS1, Line 141: hfsts1.fields.mfg_mode
This bit only reflects the regions' writability in flash descriptor. […]
Originally, the bit is named as spi_protection since it indicates writability to flash descriptor. But, recently it got updated incorrectly. This has to be reverted to avoid the confusion.
So basically fpf_soc_lock and manuf_lock should be the only bits to be checked, shouldn't they?
As part of staged EOM. these 3 conditions together reflect the EOM state. Hence, firmware has to check these 3 conditions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69324
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac605baa291ab5cc5f28464006f4828c12c748fe
Gerrit-Change-Number: 69324
Gerrit-PatchSet: 1
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Comment-Date: Tue, 08 Nov 2022 13:41:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment