Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/20979 )
Change subject: nb/intel/x4x/raminit: Move dummy reads after JEDEC init ......................................................................
Patch Set 8:
(2 comments)
the writes that get removed with this patch aren't needed?
https://review.coreboot.org/c/coreboot/+/20979/8/src/northbridge/intel/x4x/r... File src/northbridge/intel/x4x/raminit_ddr23.c:
https://review.coreboot.org/c/coreboot/+/20979/8/src/northbridge/intel/x4x/r... PS8, Line 2163: (ch << 29) | (r * 0x08000000) reimplementation of test_address(ch, r). I'd strongly suggest using the test_address function here; might be worth renaming this function though to something more descriptive like dimm_rank_offset(ch, r)
https://review.coreboot.org/c/coreboot/+/20979/8/src/northbridge/intel/x4x/r... PS8, Line 2164: 0x800000 I wonder where this offset is for
-
Felix Held (Code Review)