Attention is currently required from: Sam McNally, Tony Huang, Tim Wawrzynczak, Edward O'Callaghan, Wisley Chen.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52725 )
Change subject: mb/google/puff/var/dooly: enable touchscreen wakeup
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52725/comment/11d95d9d_bb6027f2
PS10, Line 9: Follow touchpad to set interrupt gpio to PAD_CFG_GPI_IRQ_WAKE.
Can you please rephrase this as:
Configure GPP_A20 as PAD_CFG_GPI_IRQ_WAKE to enable interrupt and wake routes for touchscreen device.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52725
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bbaab56924849a22a4d05ce53bf5bdcf00265dd
Gerrit-Change-Number: 52725
Gerrit-PatchSet: 10
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 05 May 2021 04:04:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment