Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60566 )
Change subject: soc/intel/apollolake/acpi: Replace Multiply(a,b) with ASL 2.0 syntax ......................................................................
soc/intel/apollolake/acpi: Replace Multiply(a,b) with ASL 2.0 syntax
Replace `Multiply (a, b)` with `a * b`.
Change-Id: I42076d361045c224b99e111e34de7539420b8a52 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/60566 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/soc/intel/apollolake/acpi/gpiolib.asl 1 file changed, 2 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/acpi/gpiolib.asl b/src/soc/intel/apollolake/acpi/gpiolib.asl index eb46df5..89f647e 100644 --- a/src/soc/intel/apollolake/acpi/gpiolib.asl +++ b/src/soc/intel/apollolake/acpi/gpiolib.asl @@ -60,8 +60,7 @@ Store (0, Local1) Or( Or (ShiftLeft (Arg0, 16), CONFIG_PCR_BASE_ADDRESS), Local1, Local1) - Or(PAD_CFG_BASE + Multiply (Arg1, Multiply ( - GPIO_NUM_PAD_CFG_REGS, 4)), Local1, Local1) + Or(PAD_CFG_BASE + Arg1 * GPIO_NUM_PAD_CFG_REGS * 4, Local1, Local1) Return (Local1) }
@@ -69,7 +68,7 @@ Method (CHSA, 0x1, Serialized) { /* Arg0 - GPIO pad offset relative to the community */ - Local1 = HOSTSW_OWN_REG_0 + Multiply (Divide (Arg0, 32), 4) + Local1 = HOSTSW_OWN_REG_0 + Divide (Arg0, 32) * 4 Return (Local1) }