Attention is currently required from: Arthur Heymans, Krystian Hebel, Michał Kopeć, Michał Żygowski, Patrick Rudolph, Paul Menzel.
Martin L Roth has posted comments on this change by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/82558?usp=email )
Change subject: mb/qemu-q35/smihandler.c: add support for SMIs on QEMU
......................................................................
Patch Set 10:
(2 comments)
Patchset:
PS2:
Moved the implementation to board directory. This also allowed me to fix SMM for qemu-system-i386.
Done
File src/mainboard/emulation/qemu-q35/smihandler.c:
https://review.coreboot.org/c/coreboot/+/82558/comment/2ff1248f_2eeddb5b?usp... :
PS9, Line 20: It is
: * impossible to check if SMI was generated by write to APMC port that way.
Technically possible, but not that simple. […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82558?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2fc7b74bdc13be8d76bc536283ab5a14fffec45f
Gerrit-Change-Number: 82558
Gerrit-PatchSet: 10
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Fri, 30 Aug 2024 15:44:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com