Attention is currently required from: Alexander Couzens, Arthur Heymans, Felix Singer, Krystian Hebel, Maciej Pijanowski, Michał Żygowski, Nicholas Sudsgaard, Paul Menzel.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80610?usp=email )
Change subject: mb/lenovo: Add ThinkCentre M700/M900 Tiny board (Skylake/Kaby Lake) ......................................................................
Patch Set 7:
(10 comments)
File src/mainboard/lenovo/m900_tiny/Kconfig:
https://review.coreboot.org/c/coreboot/+/80610/comment/f1a5da14_9baf20bb : PS6, Line 25: int
Remove, avoid type redefinitions.
Done
https://review.coreboot.org/c/coreboot/+/80610/comment/6d452347_1e39f09b : PS6, Line 36: hex
Remove, avoid type redefinitions.
Done
File src/mainboard/lenovo/m900_tiny/bootblock.c:
https://review.coreboot.org/c/coreboot/+/80610/comment/6c185968_6fbbeb43 : PS6, Line 13: void bootblock_mainboard_init(void) : { : mainboard_configure_early_gpios(); : }
Why is that needed? bootblock_mainboard_early_init() should work fine.
Right, moved to `bootblock_mainboard_early_init()`
File src/mainboard/lenovo/m900_tiny/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80610/comment/fa6cb39e_f2b7159d : PS6, Line 7: register "deep_s3_enable_ac" = "0" : r
Remove
Done
https://review.coreboot.org/c/coreboot/+/80610/comment/7ed613ed_bec5847e : PS6, Line 23: register "PrimaryDisplay" = "Display_iGFX"
Move into the igpu scope.
Done
https://review.coreboot.org/c/coreboot/+/80610/comment/b4d70e73_d83df76c : PS6, Line 162: [5] = 0,
Remove
Done
https://review.coreboot.org/c/coreboot/+/80610/comment/756f0083_ff717977 : PS6, Line 167: [2] = 0, : [3] = 0, : [4] = 0, :
Disabled, remove
Done
https://review.coreboot.org/c/coreboot/+/80610/comment/cb739df7_1694154b : PS6, Line 173: device ref uart2 off end # LPSS UART - pins 17, 18 on GXDP header on board underside
Please don't add disabled devices to the devicetree. Document the pins in the commit message.
Removed and added a comment to the commit message.
https://review.coreboot.org/c/coreboot/+/80610/comment/6edcce43_cc7c3824 : PS6, Line 234: device ref p2sb on end :
These are enabled in the chipset devicetree. Remove.
Done
File src/mainboard/lenovo/m900_tiny/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/80610/comment/fc44c343_e275486c : PS6, Line 10: // OEM revision
Seems superfluous, remove.
Done