Attention is currently required from: Ana Carolina Cabral.
Paul Menzel has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/84776?usp=email )
Change subject: drivers/amd/nova: Add Nova Card directory ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84776/comment/beebba6d_e6ccaae3?usp... : PS5, Line 7: directory As you add more than the directory, maybe just write “common driver”?
https://review.coreboot.org/c/coreboot/+/84776/comment/fe0c42ed_8c75d8db?usp... : PS5, Line 9: As multiple boards use the NOVA daughter card, the function that detects : the connector type has been moved to the drivers folder and : will be refactored in the soc path in the following patches. This looks a little strange. Maybe also re-flow the second and third line.
File src/drivers/amd/nova/nova_card.c:
https://review.coreboot.org/c/coreboot/+/84776/comment/4b735efb_9fbf37fa?usp... : PS5, Line 24: uint16_t connector_type = data[1] | data[0] << 8;
`please, no spaces at the start of a line`
Please fix.