Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60264 )
Change subject: mb/starlabs/labtop: Enable I2C4 ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60264/comment/5f485688_522c424b PS1, Line 9: Enable I2C4 to allow for proper enumeration but avoid FSP configuring it. nit: The period goes past the 72-char line length limit. Also, it would be good to explain why I2C4 needs to be enabled:
Enable unused I2C4 PCI device (00:19.0) so that UART2 (00:19.2) can be enumerated properly, using `PchSerialIoSkipInit` to prevent FSP-S from configuring anything regarding I2C4 (e.g. GPIOs).