Change in coreboot[master]: mb/google/brask/variants/moli: add delay time to rtd3-cold - coreboot-gerrit

14 Apr 2022


      Attention is currently required from: YH Lin, Tim Wawrzynczak, Paul Menzel, Zhuohao Lee, Felix Held.
Raihow Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63544 )
Change subject: mb/google/brask/variants/moli: add delay time to rtd3-cold
......................................................................
Patch Set 9:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63544/comment/c6d877e7_53ea4bdd 
PS1, Line 9: which will turn
           : off the eMMC controller (a true D3cold state) during the RTD3 sequence.
...
The reason is that the rise and fall times of each signal may differ by board, and so those board-sp […]
Ok, I modify the commit message, 
please review it, thanks.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63544
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idecb1c89655c9b8b720c3c65efc77e06e6a8b300
Gerrit-Change-Number: 63544
Gerrit-PatchSet: 9
Gerrit-Owner: Raihow Shi raihow_shi@wistron.corp-partner.google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Ariel Fang ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu malik_hsu@wistron.com
Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Scott Chao scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin yueherngl@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Zhuohao Lee zhuohao@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 14 Apr 2022 06:08:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Comment-In-Reply-To: Raihow Shi raihow_shi@wistron.corp-partner.google.com
Gerrit-MessageType: comment