Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34729 )
Change subject: soc/intel/common: Set power-failure-state via option table ......................................................................
soc/intel/common: Set power-failure-state via option table
Allow get_option() to override the Kconfig choice.
Change-Id: Ie91b502a38d1a40a3dea3711b017b7a5b7edd2db Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/34729 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/common/block/pmc/pmclib.c 1 file changed, 5 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/intel/common/block/pmc/pmclib.c b/src/soc/intel/common/block/pmc/pmclib.c index 7fb4d5e..d7362b6 100644 --- a/src/soc/intel/common/block/pmc/pmclib.c +++ b/src/soc/intel/common/block/pmc/pmclib.c @@ -21,7 +21,9 @@ #include <intelblocks/pmclib.h> #include <intelblocks/gpio.h> #include <intelblocks/tco.h> +#include <pc80/mc146818rtc.h> #include <soc/pm.h> +#include <stdint.h> #include <string.h> #include <timer.h> #include <security/vboot/vboot_common.h> @@ -570,9 +572,11 @@
void pmc_set_power_failure_state(const bool target_on) { - const int state = CONFIG_MAINBOARD_POWER_FAILURE_STATE; bool on;
+ uint8_t state = CONFIG_MAINBOARD_POWER_FAILURE_STATE; + get_option(&state, "power_on_after_fail"); + switch (state) { case MAINBOARD_POWER_STATE_OFF: printk(BIOS_INFO, "Set power off after power failure.\n");