Attention is currently required from: Pranava Y N, Subrata Banik.
Anil Kumar K has posted comments on this change by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/84888?usp=email )
Change subject: mb/google/fatcat: Add devicetree for MAX98357A codec
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84888/comment/91f4032e_d22cb527?usp... :
PS2, Line 618: AUDIO_MAX98360_ALC5682I_I2S
do we need to perform any GPIO programming for programming into i2s mode or already taken care ?
thsi is already taken care in fw_config changes that is merged.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84888?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I20de87f673e947f0e2332b818ebca01c0fa5e200
Gerrit-Change-Number: 84888
Gerrit-PatchSet: 2
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Mon, 28 Oct 2024 16:59:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com