Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45024 )
Change subject: libpayload/usb: Fix printf format string mismatches in debug messages ......................................................................
Patch Set 4:
should we reflow the affected areas to fit within 96 columns to keep buildbot happy? i'm not convinced that aggressively splitting format strings improves this patch.
It's either that or you can't get verified+1 the way things work right now
No, that's not how this works (unless something changed very recently that I'm not aware of). The line comments Jenkins adds from checkpatch are always purely informational and do not affect Verified+1. We know checkpatch has false positives and it's perfectly valid to ignore them if reviewers agree on that -- they're just there to make sure you don't miss something, basically. In this case I totally agree with Caveh that it's probably more readable the existing way (and there's a "long strings" exception in the coding style for this, which checkpatch doesn't account for).
Verified+1 is only affected by actual compiler failures, or by failures of linters that are marked as "stable" (which checkpatch is not). In this case, it looks like the PRIxPTR macro was not defined or the respective header not included somewhere.