Attention is currently required from: Keith Hui, Kyösti Mälkki.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74472 )
Change subject: asus/p2b: Remove MADT LAPIC
......................................................................
Patch Set 4:
(1 comment)
File src/southbridge/intel/i82371eb/Kconfig:
https://review.coreboot.org/c/coreboot/+/74472/comment/ed8fc1ae_a6f377f3
PS4, Line 2: select ACPI_COMMON_MADT_LAPIC
wouldn't "select ACPI_COMMON_MADT_LAPIC if !ACPI_NO_MADT" be a better solution here? if i'm not mistaken that should do the same thing, but be a bit clearer
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74472
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e2fbf358cf644665b897afb0a9404abb5ca1df2
Gerrit-Change-Number: 74472
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Branden Waldner
scruffy99@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 24 Apr 2023 13:54:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment