Attention is currently required from: Arthur Heymans, Felix Singer, Lance Zhao, Tim Wawrzynczak.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76008?usp=email )
Change subject: acpi/acpi.c: Split of ACPI table generation into separate files ......................................................................
Patch Set 1:
(2 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76008/comment/d93799ce_7063eefa : PS1, Line 229: static u16 acpi_sci_int(void) You might want to move this with followup. To clear the remaining #ifdef for <arch/ioapic.h> include.
https://review.coreboot.org/c/coreboot/+/76008/comment/b8b41ad9_e1c0f312 : PS1, Line 606: int acpi_create_srat_lapic(acpi_srat_lapic_t *lapic, u8 node, u8 apic) Is there something that makes MADT LAPIC entries x86-specific, but SRAT LAPICs not?
ACPI does not strictly say ARMs could not expose APIC interrupt model, but assuming GIC model and splitting this seems reasonable.