Attention is currently required from: Tim Wawrzynczak, Wisley Chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60435 )
Change subject: mb/google/brya/anahera: Correct WWAN power sequence ......................................................................
Patch Set 1:
(6 comments)
File src/mainboard/google/brya/variants/anahera/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136442): https://review.coreboot.org/c/coreboot/+/60435/comment/3ee884b6_f07e6352 PS1, Line 104: /* A12 : SATAXPCIE1 ==> EN_PPVAR_WWAN */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136442): https://review.coreboot.org/c/coreboot/+/60435/comment/bb24bcb0_f5d90494 PS1, Line 105: PAD_CFG_GPO(GPP_A12, 1, DEEP), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136442): https://review.coreboot.org/c/coreboot/+/60435/comment/8a006719_27d10dfd PS1, Line 105: PAD_CFG_GPO(GPP_A12, 1, DEEP), please, no spaces at the start of a line
File src/mainboard/google/brya/variants/anahera4es/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136442): https://review.coreboot.org/c/coreboot/+/60435/comment/50583a1f_9e950b1e PS1, Line 104: /* A12 : SATAXPCIE1 ==> EN_PPVAR_WWAN */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136442): https://review.coreboot.org/c/coreboot/+/60435/comment/2cc87a93_c52c9c3e PS1, Line 105: PAD_CFG_GPO(GPP_A12, 1, DEEP), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136442): https://review.coreboot.org/c/coreboot/+/60435/comment/da7d56f7_b797e863 PS1, Line 105: PAD_CFG_GPO(GPP_A12, 1, DEEP), please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)