Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Daniel Peng has posted comments on this change by Daniel Peng. ( https://review.coreboot.org/c/coreboot/+/84925?usp=email )
Change subject: mb/google/nissa/var/glassway: Add initial LTE related settings ......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84925/comment/84b1e859_83ad5ede?usp... : PS2, Line 7: Initial LTE Related Settings
Please make it a statement by adding a verb (in imperative mood): […]
Done
https://review.coreboot.org/c/coreboot/+/84925/comment/2e47ebf7_b31c36e8?usp... : PS2, Line 9: fw_config .
Please remove the space before the dot/period, or remove the period at the end of the items.
Done
https://review.coreboot.org/c/coreboot/+/84925/comment/6a712f2a_22c85a6b?usp... : PS2, Line 12: SX9324(P-sensor)
Please add a space before (.
Done
https://review.coreboot.org/c/coreboot/+/84925/comment/71680e39_6702ac57?usp... : PS2, Line 12: 4. Add I2C SX9324(P-sensor) support.
What is the sensor needed for in LTE setting? Should the proximity sensor be a separate commit?
I just know that both SX9324 and LTE setting have relationship. That's why we set DB_1C_LTE for I2C SX9324 device in override.cb. On your experience, I could separate this CL to 2 commit if need?
https://review.coreboot.org/c/coreboot/+/84925/comment/87267384_8b006487?usp... : PS2, Line 13:
Please add the schematics file name.
Done