[S] Change in coreboot[main]: cpu/intel/model_206ax: Allow PL1/PL2 configuration

[Nico Huber (Code Review)]

Attention is currently required from: Anastasios Koutian, Angel Pons, Patrick Rudolph, Paul Menzel.

Nico Huber has posted comments on this change by Anastasios Koutian. ( https://review.coreboot.org/c/coreboot/+/83269?usp=email )

Change subject: cpu/intel/model_206ax: Allow PL1/PL2 configuration
......................................................................

Patch Set 2: Code-Review+1

(2 comments)

File src/cpu/intel/model_206ax/chip.h:

https://review.coreboot.org/c/coreboot/+/83269/comment/55805558_c6bf4b3c?usp... :
PS1, Line 46: int pl1; /* Long-term power limit*/
            : 	int pl2; /* Short-term power limit*/
> Done

No too strong feelings about this, but I suggest to change it to milliwatts.
Having all those zeros attached and having to count them every time when
reading a value seems unnecessary. Even if we pretend not to know the
`power_unit` (we do know, though, it's always 8 for these chips. and
given the 15-bit width of the programmed value, we also know it (the
`power_unit`) has to be <1000).

Now I've also noticed that the `unsigned int` could easily overflow if
`power_unit` was much higher. Microwatts just doesn't feel right.

File src/cpu/intel/model_206ax/model_206ax_init.c:

https://review.coreboot.org/c/coreboot/+/83269/comment/2beb1107_4dcff92a?usp... :
PS1, Line 99: dev->upstream->dev->upstream->children->chip_info;
> Yeah, you're right. I didn't know we model a single chip as two in the devicetree.

Merged CB:83275. Please rebase.