Attention is currently required from: Tim Wawrzynczak.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56802 )
Change subject: mb/google/brya/variant/taeko: Update devicetree settings
......................................................................
Patch Set 15:
(3 comments)
File src/mainboard/google/brya/variants/taeko/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56802/comment/55c8644d_b09098e1
PS14, Line 119: 0x2c
nit: all the other i2c addresses in this file do not use the `0x` prefix. drop it for consistency.
Done
https://review.coreboot.org/c/coreboot/+/56802/comment/2e78a858_1b983e20
PS14, Line 193: device ref pmc hidden
Above the `pmc` device, I think you want to add: […]
Done
https://review.coreboot.org/c/coreboot/+/56802/comment/8f6ba5af_1a2f2791
PS14, Line 204: conn2
nit: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56802
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96aaf48284a226edc39115f870bf0f3dd83ab8b4
Gerrit-Change-Number: 56802
Gerrit-PatchSet: 15
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 11 Aug 2021 01:02:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment