Attention is currently required from: Matt DeVillier.
Martin Roth has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83606?usp=email )
Change subject: mb/google/dedede/var/galtic: Add fw_config option for touchpad type ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/dedede/variants/galtic/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83606/comment/c3c73e13_45b942b9?usp... : PS1, Line 12: TOUCHPAD_SOURCE 44 45 Unless Google actually makes this change as well, setting it as the next bits in the bitfield could cause issues if they decide to add something else. Maybe this isn't a concern if they've stopped producing this board.
My recommendation would be to put this in bits 63 & 62 so it's less likely to conflict with anything google does.
If they are still producing this board, maybe google could make this an official change, since this is how it should have been done in the first place.