Attention is currently required from: Angel Pons, Kyösti Mälkki, Elyes Haouas, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69339 )
Change subject: Revert "mb/aopen/dxplplusu: Remove board" ......................................................................
Patch Set 4:
(9 comments)
File src/northbridge/intel/e7505/northbridge.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162958): https://review.coreboot.org/c/coreboot/+/69339/comment/12a1b330_aa2b79d8 PS4, Line 72: if (dev->path.type == DEVICE_PATH_DOMAIN) { braces {} are not necessary for any arm of this statement
File src/northbridge/intel/e7505/raminit.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162958): https://review.coreboot.org/c/coreboot/+/69339/comment/b418cb5b_48ec2b67 PS4, Line 175: while (i--) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162958): https://review.coreboot.org/c/coreboot/+/69339/comment/bc785a92_e628dc59 PS4, Line 696: BUG(); Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162958): https://review.coreboot.org/c/coreboot/+/69339/comment/52959287_84c32496 PS4, Line 1187: if (!(dimm_mask & (1 << i))) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162958): https://review.coreboot.org/c/coreboot/+/69339/comment/df81cb3d_3dd51081 PS4, Line 1204: if (value != ERROR_SCHEME_ECC) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162958): https://review.coreboot.org/c/coreboot/+/69339/comment/55db7669_8d6f0af6 PS4, Line 1274: if (sdram_width.side1 == 4) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162958): https://review.coreboot.org/c/coreboot/+/69339/comment/30205a44_0c3139c2 PS4, Line 1278: if (sdram_width.side2 == 4) { braces {} are not necessary for single statement blocks
File src/southbridge/intel/i82801dx/i82801dx.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162958): https://review.coreboot.org/c/coreboot/+/69339/comment/3b036287_54db1f84 PS4, Line 55: if (!dev->enabled) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162958): https://review.coreboot.org/c/coreboot/+/69339/comment/fc556200_a781c301 PS4, Line 58: if (new_disable_mask != cur_disable_mask) { braces {} are not necessary for single statement blocks
-
build bot (Jenkins) (Code Review)