Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Fred Reitberger, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63313 )
Change subject: soc/amd/sabrina: Allow to specify custom SPL File ......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63313/comment/7c9cf411_750b2ebf PS1, Line 7: Build support to add SPL File
Please make it a statement: […]
Done
https://review.coreboot.org/c/coreboot/+/63313/comment/aa204db5_b5023878 PS1, Line 14: Boot
boot
Done
https://review.coreboot.org/c/coreboot/+/63313/comment/5e266c53_6bf2782c PS1, Line 14: SPL file
Mention the file you used?
Done
File src/soc/amd/sabrina/Kconfig:
https://review.coreboot.org/c/coreboot/+/63313/comment/2c11fb06_2f461611 PS1, Line 394: which is created by AMD
Why can it only be created by AMD?
Done
https://review.coreboot.org/c/coreboot/+/63313/comment/6a0a2d67_bba53f20 PS1, Line 394: Have a mainboard specific SPL table file, which is created by AMD
would be good to mention that this is an override of the default one in amd_blobs
Done
https://review.coreboot.org/c/coreboot/+/63313/comment/aca8506e_dc1bb068 PS1, Line 394: Have a mainboard specific SPL table file, which is created by AMD
Please add a line, what an SPL file is.
Done
-
Karthik Ramasubramanian (Code Review)