Change in coreboot[master]: src/mediatek/mt8186: Get dram size from mtk ddr info or CBMEM_ID_MEMINFO
Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Xixi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62065 )
Change subject: src/mediatek/mt8186: Get dram size from mtk ddr info or CBMEM_ID_MEMINFO ......................................................................
Patch Set 17:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62065/comment/80a77f11_dc4c52bd PS14, Line 10: should update from
calculate it from the mem chip info stored in
Ack
https://review.coreboot.org/c/coreboot/+/62065/comment/282ed393_6787968b PS14, Line 13: TEST=Build pass on Kingler
Did you see the correct "dram size: ... […]
yes.
File src/soc/mediatek/common/include/soc/emi.h:
https://review.coreboot.org/c/coreboot/+/62065/comment/03a2a3a1_530ff3f3 PS15, Line 9: size_t mtk_dram_size(void); /* MTK dram size internal interface */
This should be added in the previous CL. No need for comments.
Ack
File src/soc/mediatek/mt8186/emi.c:
https://review.coreboot.org/c/coreboot/+/62065/comment/04e22090_c2808619 PS14, Line 16: p
channel
Ack
https://review.coreboot.org/c/coreboot/+/62065/comment/ed6b53c8_2cde221f PS14, Line 17: uint64_t
size_t
Ack
https://review.coreboot.org/c/coreboot/+/62065/comment/515c862d_89a7cd1a PS14, Line 20: != NULL
Remove
Ack
File src/soc/mediatek/mt8186/emi.c:
https://review.coreboot.org/c/coreboot/+/62065/comment/198cf5be_38b129e9 PS15, Line 20: size = mtk_dram_size();
Do we need to add memory.c to ramstage in Makefile. […]
No need, ramstage won't compile if (ENV_ROMSTAGE), the same to if (0).
-
Xixi Chen (Code Review)