Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu, yuchi.chen@intel.com.
Jérémy Compostella has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/84252?usp=email )
Change subject: arch/x86: Define macros for hard-coded HPET registers
......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84252/comment/10daae61_127e4e3f?usp... :
PS5, Line 11: HEPT
HPET ?
https://review.coreboot.org/c/coreboot/+/84252/comment/bd488bf0_bd8bad87?usp... :
PS5, Line 14: date
the `date` word is unnecessary
File src/arch/x86/include/arch/hpet.h:
https://review.coreboot.org/c/coreboot/+/84252/comment/8f4d420c_6ea4d115?usp... :
PS5, Line 10: Date
Same here, I don't think the work `Date` brings any value.
https://review.coreboot.org/c/coreboot/+/84252/comment/0803cbd5_65f779e0?usp... :
PS5, Line 17: #define HPET_TIMER_FSB_EN_CNF_MASK (1 << 15)
BIT(15) ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84252?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I31413afcbfc42307e3ad3f99d75f33f87092d7aa
Gerrit-Change-Number: 84252
Gerrit-PatchSet: 5
Gerrit-Owner: yuchi.chen@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 27 Sep 2024 21:31:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No